Skip to content

fix: review cleanup — dead code, regex consolidation, unreachable fix - #28

Merged
CodeSigils merged 1 commit into
mainfrom
fix/review-cleanup
Aug 21, 2026
Merged

fix: review cleanup — dead code, regex consolidation, unreachable fix#28
CodeSigils merged 1 commit into
mainfrom
fix/review-cleanup

Conversation

@CodeSigils

Copy link
Copy Markdown
Owner

5 cleanup fixes from code review:

  1. Remove dead contains_markdown_phrase() from _common.py (never called)
  2. Consolidate SKILL_REF_RE — import from _common in cron-health.py instead of duplicating
  3. Fix misspelled AssertionErrorRuntimeError in _url_contract.py:127
  4. Simplify version check — replace over-complex most_common() with direct comparison
  5. (automatic) Remove redundant import re as _re inside deleted function

Net: -14 lines. All 35 tests pass, ruff clean, LSP clean.

@CodeSigils
CodeSigils merged commit fbc69d3 into main Aug 21, 2026
7 checks passed
@CodeSigils
CodeSigils deleted the fix/review-cleanup branch August 21, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant