fix: report actionable diagnostic for overlong unix socket paths - #13
Open
Vrindakr3300 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detects overlong Unix socket paths before bind, connect, or daemon spawn operations on Unix platforms, failing fast with an actionable diagnostic message instead of encountering a low-level bind failure or generic 15-second server readiness timeout.
Closes #3
Key Changes
src/ipc.rs):max_unix_socket_path_len()inspectinglibc::sockaddr_un'ssun_pathlength minus null byte (103 bytes on macOS/BSDs, 107 bytes on Linux).validate_socket_path()returning anInvalidInputerror with the configured path, byte length vs. platform limit, and remediation suggestion (set a shorter NAGI_CONFIG_PATH or XDG_CONFIG_HOME).bind_local_listener,connect_local_stream, andprepare_socket_path.src/server/autodetect.rs):socket_path()) and client (client_socket_path()) paths at entry ofauto_detect_launch()andwait_for_server_socket().src/ipc.rs,src/server/autodetect.rs, andsrc/server/socket_paths.rsverifying path limit enforcement and error diagnostics.Example Output
socket path exceeds Unix domain socket limit (120 bytes > 103 bytes): /path/to/deeply/nested/nagi.sock; set a shorter NAGI_CONFIG_PATH or XDG_CONFIG_HOME