Skip to content

test: unify e2e utils across e2e/deployment/openshift tests - #304

Merged
GrigoryPervakov merged 3 commits into
mainfrom
e2e-testutil-env
Aug 25, 2026
Merged

test: unify e2e utils across e2e/deployment/openshift tests#304
GrigoryPervakov merged 3 commits into
mainfrom
e2e-testutil-env

Conversation

@GrigoryPervakov

Copy link
Copy Markdown
Member

Why

E2e suites tend to have local helpers that are useful in all of them
This is a preparation step for the later E2E enhancements.

What

Deduplicate and reuse code between different e2e tests suites

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Centralizes reusable E2E helpers across the E2E, deployment, and OpenShift suites.

Changes:

  • Introduces shared environment, readiness, namespace, and read/write helpers.
  • Moves diagnostics reporting into a dedicated utility.
  • Replaces suite-local implementations with shared helpers.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/testutil/wait.go Adds shared readiness and rollout helpers.
test/testutil/utils.go Adds shared test-namespace helpers.
test/testutil/report.go Centralizes diagnostic collection.
test/testutil/env.go Defines shared test environment handles.
test/testutil/checks.go Centralizes cluster read/write checks.
test/openshift/openshift_test.go Adopts shared helpers.
test/e2e/keeper_e2e_test.go Removes duplicated Keeper helpers.
test/e2e/e2e_suite_test.go Initializes and uses the shared environment.
test/e2e/clickhouse_e2e_test.go Removes duplicated ClickHouse helpers.
test/deploy/deploy_test.go Adopts shared deployment and readiness helpers.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/testutil/wait.go
@GrigoryPervakov
GrigoryPervakov merged commit ed63e57 into main Aug 25, 2026
44 of 47 checks passed
@GrigoryPervakov
GrigoryPervakov deleted the e2e-testutil-env branch August 25, 2026 18:20
@mintlify

mintlify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Docs PR opened: ClickHouse/ClickHouse#116379

Synced the operator's network policies guide and API reference to document new managed NetworkPolicy support for ClickHouse and Keeper clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants