test: unify e2e utils across e2e/deployment/openshift tests - #304
Merged
Conversation
GrigoryPervakov
force-pushed
the
e2e-testutil-env
branch
from
August 25, 2026 16:50
9543a1f to
bebe40d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes reusable E2E helpers across the E2E, deployment, and OpenShift suites.
Changes:
- Introduces shared environment, readiness, namespace, and read/write helpers.
- Moves diagnostics reporting into a dedicated utility.
- Replaces suite-local implementations with shared helpers.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/testutil/wait.go |
Adds shared readiness and rollout helpers. |
test/testutil/utils.go |
Adds shared test-namespace helpers. |
test/testutil/report.go |
Centralizes diagnostic collection. |
test/testutil/env.go |
Defines shared test environment handles. |
test/testutil/checks.go |
Centralizes cluster read/write checks. |
test/openshift/openshift_test.go |
Adopts shared helpers. |
test/e2e/keeper_e2e_test.go |
Removes duplicated Keeper helpers. |
test/e2e/e2e_suite_test.go |
Initializes and uses the shared environment. |
test/e2e/clickhouse_e2e_test.go |
Removes duplicated ClickHouse helpers. |
test/deploy/deploy_test.go |
Adopts shared deployment and readiness helpers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
GrigoryPervakov
force-pushed
the
e2e-testutil-env
branch
from
August 25, 2026 17:43
bebe40d to
e96eeee
Compare
|
Docs PR opened: ClickHouse/ClickHouse#116379 Synced the operator's network policies guide and API reference to document new managed NetworkPolicy support for ClickHouse and Keeper clusters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
E2e suites tend to have local helpers that are useful in all of them
This is a preparation step for the later E2E enhancements.
What
Deduplicate and reuse code between different e2e tests suites