test: improve e2e failure diagnostics report - #299
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves end-to-end (e2e) failure diagnostics for flaky e2e-compat runs by enriching namespace resource dumps (with condition/state summaries) and by replacing kubectl wait calls with a Go helper that emits more informative readiness failures for ClickHouse/Keeper CRs.
Changes:
- Add concise, per-object summary lines to namespace resource dumps (including ClickHouseCluster/KeeperCluster conditions, Job counters, and Pod state/restarts).
- Include ClickHouse/Keeper CRDs in the diagnostics resource collection.
- Introduce a
waitClusterReadyhelper in e2e deployment tests that reports readiness failures with formatted CR conditions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/testutil/utils.go | Enhances diagnostics output by summarizing object state/conditions in short resource dumps and including operator CRs. |
| test/deploy/deploy_test.go | Replaces kubectl wait calls with a helper that waits for CR readiness and prints condition details on failure. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Most e2e-compat flaky failures are hard to diagnose to fix
What
Provide more details in logs