fix(spatch): make multi-file writes transactional - #11
Draft
ClaudiuCeia with Copilot wants to merge 2 commits into
Draft
fix(spatch): make multi-file writes transactional#11ClaudiuCeia with Copilot wants to merge 2 commits into
ClaudiuCeia with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix multi-file writes to be transactional
fix(spatch): make multi-file writes transactional
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-interactive writes analyzed and wrote files concurrently, so a later write failure left earlier files modified. Interactive mode preflighted selected files but its sequential write loop could still partially apply across files.
Changes
file-write.ts— transaction primitivesFileWriteFs(was unexported)TransactionEntry— staged write descriptor (filePath,originalText,rewrittenText,encoding,operationName)PartialCommitError— typed error with deterministically sortedaffectedFiles: readonly string[]; thrown when rollback cannot restore all committed filescommitTransaction(entries, options?):originalText) — any mismatch aborts before any writePartialCommitErroron incomplete rollback; otherwise rethrow the original commit errorrewrite.ts— separate analysis from mutationrewriteFileintoanalyzeFile, which reads/matches/renders but does not writeanalyzeFilereturns{ fileResult, writeEntry }—writeEntryisnullfor dry-run or no-change filesrewriteProjectrunsanalyzeFileconcurrently, collectsTransactionEntryitems, then callscommitTransactiononce — any analysis failure aborts before any file is touchedrun.ts(interactive) — route through shared transactionwriteFileIfUnchangedAtomicallyloop with a singlecommitTransactioncall over all prepared filesTests
commitTransaction: empty entries, multi-file write, deterministic order, stale preflight abort, commit failure + successful rollback, rollback failure →PartialCommitError, concurrent edit preserved, error shape