Fix lint and formatting breakage on develop blocking all PR CI - #501
Merged
Conversation
PR #491 introduced two pep8 violations (E501 in manage_fabrics.py, E303 in test_config_actions_mixin.py) and two pylint disallowed-name violations (`_` assignments in the configSave/deploy endpoint tests), failing the stable-2.18 sanity jobs on every open PR since CI tests the merge with develop. Independently, psf/black@stable moved forward and now parenthesizes multi-item `with` statements and adds magic trailing commas, so the "Pep8 Compliance - Black" check fails on four files last formatted under an older black. Also replace `a is not type(None)` with `a is not types.NoneType` in manage_fabric_base.py: the pylint shipped with newer ansible-core flags it as unidiomatic-typecheck (Python floor is 3.10, so types.NoneType is always available). Verified in nd-dev: ansible-test sanity pep8 and pylint pass, black --check clean across plugins/ and tests/, isort clean on changed files, and 1841 unit tests in the touched areas pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sbmW5b5UXHqMEwV7ysq2G
allenrobel
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
mikewiebe,
mtarking,
sajagana,
samiib and
shrsr
as code owners
August 10, 2026 21:29
samiib
approved these changes
Aug 10, 2026
mtarking
approved these changes
Aug 10, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
None — unblocks CI for all open PRs (first observed on #454; violations introduced by #491 plus black-version drift).
Proposed Changes
class_nameField line inmanage_fabrics.py(E501) and drop the double blank line intest_config_actions_mixin.py(E303).disallowed-nameviolations from Address fabric module issues and fix save without switches issue (NDA-35) #491: replace_ = instance.pathwithresult = instance.path # pylint: disable=unused-variablein the configSave/deploy endpoint tests, matching the existing convention in sibling endpoint tests.psf/black@stable(parenthesized multi-itemwithstatements, magic trailing commas):nd_output.py,test_nd_manage_networks.py,test_nd_manage_vrfs.py,test_manage_resource_manager.py. These fail the "Pep8 Compliance - Black" check on every PR because the stable black version moved forward since they were last formatted.a is not type(None)witha is not types.NoneTypeinmanage_fabric_base.py— the pylint bundled with newer ansible-core flags it asunidiomatic-typecheck(Python floor is 3.10, sotypes.NoneTypeis always available).All changes are mechanical lint/format fixes; no behavior changes.
Test Notes
ansible-test sanity --test pep8and--test pylintpass (nd-dev container machine)black --checkclean acrossplugins/andtests/(line length 159)isort --check-onlyclean on changed filesCisco Nexus Dashboard Version
4.2.1
Related ND API Resource Category
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_011sbmW5b5UXHqMEwV7ysq2G