Staged configuration addition and removal audit for Vrf_lite - #494
Draft
sivakasi-cisco wants to merge 3 commits into
Draft
Staged configuration addition and removal audit for Vrf_lite#494sivakasi-cisco wants to merge 3 commits into
sivakasi-cisco wants to merge 3 commits into
Conversation
sivakasi-cisco
marked this pull request as ready for review
August 13, 2026 05:34
sivakasi-cisco
requested review from
akinross,
allenrobel,
anvitha-jain,
gmicol,
lhercot,
mikewiebe,
mtarking,
sajagana,
samiib and
shrsr
as code owners
August 13, 2026 05:34
sivakasi-cisco
marked this pull request as draft
August 13, 2026 05:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VRF Lite attachments staged with deploy=false were skipped as "no change"
on a subsequent run that requested deploy=true with the same configuration,
leaving controller-pending intent undeployed. Discover that pending intent
during query and redeploy it instead of treating it as idempotent.
as pending; publish _pending_deploy_targets (write/delete op per attachment)
and _not_in_sync_vrfs for downstream consumers.
pairs, replaced -> configured VRFs, overridden -> all, deleted -> delete ops),
honor disabled_vrfs/disabled_pairs, and gate deployment on scoped pending
targets in _needs_deployment; swallow the non-fatal HTTP 500 vPC config-save
sanity error.
to delete" warning for staged pending-deletes.
targets into changed_vrfs, and gate on _needs_deployment.
update merge integration tasks to re-deploy staged intent until idempotent.
Fixes #468