Remove legacy ND ≤3.2 modules for 2.0.0 (unified ND) (NDA-33) - #493
Draft
mtarking wants to merge 1 commit into
Draft
Remove legacy ND ≤3.2 modules for 2.0.0 (unified ND) (NDA-33)#493mtarking wants to merge 1 commit into
mtarking wants to merge 1 commit into
Conversation
cisco.nd 2.0.0 targets the unified Nexus Dashboard (4.2+) OpenAPI. Modules that only work against ND 3.2 and earlier are removed and tombstoned in meta/runtime.yml. Also removes their integration targets and the now-orphaned ndi module_utils/doc_fragments, rebuilds action_groups.all with the surviving unified modules, bumps the collection to 2.0.0, and adds a changelog fragment. To manage ND <=3.2, pin cisco.nd to a 1.x release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cisco.nd2.0.0 targets the unified Nexus Dashboard (4.2+) OpenAPI. The modules that only work against ND 3.2 and earlier no longer function on the new controller, so this PR removes them and tombstones them for 2.0.0.Because there is no intermediate 1.x release to deprecate in, this is a single-release removal: entries go straight to
tombstone:inmeta/runtime.yml(referencing a removed module now fails with an actionable message pointing at the ND-version limitation). To manage ND ≤3.2, users pincisco.ndto a1.xrelease and isolate the two generations in separate venvs / Execution Environments (only one version of a collection can be installed per collection path).What changed
tests/integration/targets/):nd_compliance_analysis,nd_compliance_requirement_communication,nd_compliance_requirement_config_import,nd_compliance_requirement_config_manual,nd_compliance_requirement_config_snapshot,nd_compliance_requirement_config_template,nd_delta_analysis,nd_flow_rules,nd_interface_flow_rules,nd_instant_assurance_analysis,nd_pcv,nd_pcv_compliance,nd_pcv_delta_analysis,nd_policy_cam_statistics_hit_counts,nd_snapshotnd_api_key,nd_backup,nd_backup_restore,nd_cluster_config_route,nd_federation_member,nd_service,nd_service_instance,nd_setup,nd_site,nd_versionnd_epochrouting converted fromredirect: nd_snapshot→tombstone(its redirect target was removed).plugins/module_utils/ndi.py,plugins/module_utils/ndi_argument_specs.py,plugins/doc_fragments/ndi_compliance_base.py(verified no surviving module imports them).meta/runtime.yml: added 26tombstoneentries and rebuiltaction_groups.allwith the 31 surviving unified modules (previously it listed only the legacy set +nd_rest).galaxy.yml:1.5.0→2.0.0(required: tombstones need the collection version ≥removal_version).breaking_changes+removed_features.nd_versionexamples inREADME.mdandplugins/modules/nd_log.pywithnd_restequivalents.Modules retained (31)
All
nd_manage_*,nd_interface_*(non-flow),nd_fabric_update_group,nd_local_user,nd_log,nd_maintenance_mode, andnd_rest.Reviewer notes / open questions
nd_api_key,nd_backup,nd_backup_restore,nd_federation_member,nd_service*,nd_setup,nd_site) is removed here rather than reworked onto unified APIs. If any of these should instead be re-implemented against ND 4.2+ endpoints, flag it and I'll pull it out of the removal set.ansible-test sanity/ changelog lint) and confirmation of the base branch.Verification done locally
meta/runtime.yml,galaxy.yml, and the changelog fragment.plugins/,README.md, ormeta/references to removed modules (only an unrelated internalnd_versionparameter mention in the multisite orchestrator docstrings).ignore-*.txtentries referenced the removed modules.