Skip to content

Admit BoardCanvas spec to frontend typecheck - #2747

Merged
Chris0Jeky merged 2 commits into
mainfrom
issue-1607/boardcanvas
Sep 6, 2026
Merged

Admit BoardCanvas spec to frontend typecheck#2747
Chris0Jeky merged 2 commits into
mainfrom
issue-1607/boardcanvas

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • Fix the two current BoardCanvas fixture type errors (Column.cardCount and Card.description).
  • Remove only BoardCanvas.spec.ts from the frontend Vitest typecheck quarantine.

Verification

  • Scratch admission probe: vue-tsc exits 0 with only this spec admitted.
  • npx vitest --run --maxWorkers=2 "src/tests/components/BoardCanvas.spec.ts" (4 passed)
  • npm run typecheck
  • npm run build (known pre-existing ineffective dynamic-import warning)
  • npx eslint "src/tests/components/BoardCanvas.spec.ts"
  • git diff --check

No merge or issue close performed. Refs #1607

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Fresh-context review record (coordinator, 2026-09-06; read-only Opus 5 reviewer over the diff against the merge base; route: the standing D-12 rule for Codex-session PRs — review, fix MEDIUM+ in-PR, merge, disposition comment).

VERDICT: SHIP (round 1). Fixture fixes verified against src/types/board.ts (cardCount: number, description: string), exactly one exclusion removed, include untouched so no other spec is admitted, and vue-tsc -b surfaces any dependency-side error in the Frontend Unit lane. Fixed in-PR (round 2, coordinator commit a01d2d21f): MEDIUM-1 — the in-file quarantine ledger still said 40 files / 391 errors / 262 of 326 specs; it now reads 39 / 389 / 263 with the admission dated. docs/STATUS.md:671,673 carries the same 40-file figure and is corrected in the next STATUS block (coordinator lease).

@Chris0Jeky
Chris0Jeky merged commit 7b60e6b into main Sep 6, 2026
35 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-1607/boardcanvas branch September 6, 2026 12:41
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant