Skip to content

[1135] Add Vue file size warning - #2742

Open
Chris0Jeky wants to merge 1 commit into
mainfrom
issue-1135/size-guard
Open

[1135] Add Vue file size warning#2742
Chris0Jeky wants to merge 1 commit into
mainfrom
issue-1135/size-guard

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • add a warn-level core ESLint max-lines guard for Vue SFCs at 700 nonblank, noncomment lines
  • explicitly allowlist the nine current high-cohesion exceptions with local rationale comments
  • keep the existing --max-warnings=20 budget unchanged and scope the rule away from TypeScript

Proof

  • synthetic short SFC: no max-lines warning
  • synthetic 705-line unlisted SFC: one max-lines warning
  • synthetic 701-line TypeScript control: no max-lines warning
  • npm run lint (8 pre-existing warnings, 0 errors)
  • npm run typecheck
  • npm run build (known ineffective dynamic-import warning only)
  • git diff --check

Refs #1135

No issue close or merge requested; this PR is intentionally left open for review.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

1 participant