Skip to content

Ignore composing Enter in workspace setup - #2740

Open
Chris0Jeky wants to merge 1 commit into
mainfrom
issue-2229/ime-enter
Open

Ignore composing Enter in workspace setup#2740
Chris0Jeky wants to merge 1 commit into
mainfrom
issue-2229/ime-enter

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • ignore Enter while the workspace board-name input is composing IME text
  • keep ordinary Enter on the same guarded submit path
  • add a focused regression for composing and ordinary Enter behavior

Verification

  • red-first focused suite: failed because composing Enter called createBoard once before the guard
  • final npx vitest --run --maxWorkers=2 "src/tests/components/WorkspaceSetupModal.spec.ts" --reporter=verbose: 7 passed
  • npm run typecheck: passed
  • production build: passed; existing ineffective toastStore dynamic-import warning remains
  • scoped ESLint: passed
  • git diff --check: passed

This is the bounded keyboard residual from #2229. Date-field and release-workflow residuals remain separate.

Refs #2229

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

1 participant