Skip to content

Localize remaining Paper capture composer copy - #2739

Merged
Chris0Jeky merged 3 commits into
mainfrom
issue-1871/composer-copy
Sep 6, 2026
Merged

Localize remaining Paper capture composer copy#2739
Chris0Jeky merged 3 commits into
mainfrom
issue-1871/composer-copy

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • move the remaining PaperCaptureComposer header, metadata, footer, and submit copy into the Inbox catalogs
  • add Spanish and Italian translations alongside English
  • prove first-render and post-mount locale switching without changing composer behavior or stable selectors

Verification

  • red-first baseline detector failed because the baseline composer still contained all four target literals
  • current source literal detector passed; all four target literals are catalog-backed
  • focused composer and catalog suites: 64 passed
  • npm run typecheck: passed
  • production build: passed; existing ineffective toastStore dynamic-import warning remains
  • scoped ESLint: passed with one pre-existing label-has-for warning at PaperCaptureComposer.vue:355
  • git diff --check: passed

The slice is limited to the remaining composer-copy residual from #1871. The review-i18n half and other Inbox bare-English residuals remain out of scope.

Refs #1871

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Fresh-context review record (coordinator, 2026-09-06; read-only Opus 5 reviewer over the diff against the merge base; route: the standing D-12 rule for Codex-session PRs — review, fix MEDIUM+ in-PR, merge, disposition comment).

VERDICT: SHIP (round 1). Fixed in-PR (round 2, coordinator commit on this branch; composer specs and the catalog guard green): MEDIUM-1 — the footer's <span class="tk-ink-italic">Inbox</span> emphasis (a real Paper token: serif italic in ember) was flattened into one plain string, so the word lost its treatment on every render and the .text() assertion could not see it. The footer is now three parallel keys (footerBefore, footerInbox, footerAfter) in all three catalogs and the template re-wraps the middle one; rendered text is byte-identical.

Recorded, not fixed: LOW — the English meta string is recapitalised ("saves to Inbox") versus the source literal ("saves to inbox"), a defensible product-name fix but undisclosed in the body; LOW — the catalog doc-comment above composer: still describes only the field chrome and does not mention the four (now six) new keys.

@Chris0Jeky
Chris0Jeky merged commit 8a6af35 into main Sep 6, 2026
35 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-1871/composer-copy branch September 6, 2026 12:30
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant