Skip to content

Handle card comment load rejection - #2735

Merged
Chris0Jeky merged 3 commits into
mainfrom
issue-2129/comments-rejection
Sep 6, 2026
Merged

Handle card comment load rejection#2735
Chris0Jeky merged 3 commits into
mainfrom
issue-2129/comments-rejection

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • attach a rejection handler to CardModal comment loads on open and card switch
  • keep store-owned error/toast handling and cached comments intact
  • continue provenance/editing setup when comments fail and cover stale A-to-B rejection ordering

The prepared CardModal locator resolves to useCardModal.ts on the current base; no CardModal template change was needed.

Verification

  • baseline after adding detectors: 1 failed test with 2 unhandled rejections
  • final focused CardModal Vitest: 33/33 passed
  • npm run typecheck: passed
  • npm run build: passed; existing ineffective dynamic-import warning remains
  • scoped ESLint: passed
  • git diff --check: passed

The parent issue remains open for its other independent inspector follow-ups.

Refs #2129

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Fresh-context review record (coordinator, 2026-09-06; read-only Opus 5 reviewer over the diff against the merge base; route: the standing D-12 rule for Codex-session PRs — review, fix MEDIUM+ in-PR, merge, disposition comment).

VERDICT: SHIP (round 1). Fixed in-PR (round 2, coordinator commit bfc121478; CardModal.spec.ts and useCardModal.spec.ts 97/97): MEDIUM-1 — the new empty catch removed the only error-reporting sink for a comment-load failure (the rejection used to reach the window/Vue error handlers, which log and report to Sentry; handleApiError sets state and a toast but never logs), so a session where comments 500 on every card would show transient toasts and nothing in console or Sentry. The catch now calls logError, as every other catch in the file does.

Tracked for #2129, not fixed: LOW (pre-existing) — a rejected load renders "No comments yet." in CardModalComments.vue, the honest-empty lie class; LOW — the new "stale rejection" test's assertions also pass on base (it discriminates only through vitest's unhandled-rejection reporting); LOW — a now-false ordering comment in useCardModal.spec.ts:253-255; LOW — one tautological get(...).exists() assertion.

@Chris0Jeky
Chris0Jeky merged commit 881c560 into main Sep 6, 2026
35 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-2129/comments-rejection branch September 6, 2026 12:30
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant