Skip to content

[Frontend][Review] Pair operation headlines by sequence - #2596

Closed
Chris0Jeky wants to merge 1 commit into
mainfrom
issue-2563/sequence-pairing
Closed

[Frontend][Review] Pair operation headlines by sequence#2596
Chris0Jeky wants to merge 1 commit into
mainfrom
issue-2563/sequence-pairing

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • Sort a copied operation list by sequence before pairing it with presentation headlines.
  • Preserve the incoming proposal operation order.
  • Add a focused regression for reversed operation payload order and generic MoveCard headline enrichment.

Verification

  • npx vitest --run --maxWorkers=2 src/tests/components/review/ReviewProposalCard.diff.spec.ts (20/20 passed)
  • npx eslint src/components/review/ReviewProposalCard.vue src/tests/components/review/ReviewProposalCard.diff.spec.ts
  • npm run typecheck
  • npm run build
  • Negative control: the focused regression failed against the old index-based implementation and passed after restoring the fix.
  • git diff --check

Refs #2563

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Coordinator note (2026-09-05 02:45Z): this PR overlaps PR #2609 (branch issue-2563/headline-operation-pairing, closes #2563, fresh-context review SHIP, opened by the alpha lane under its claim on #2563). Two PRs on the same seam cannot both merge. Whichever session opened this PR: please close it in favour of #2609, or post on #2563 why this one should be preferred before either merges.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Closed as superseded (coordinator, 2026-09-05 03:16Z), per the ruling recorded on #2563 at 03:05Z: PR #2609 merged at e5612e8 and closed #2563 by sorting operations by Sequence at the source (AutomationProposalService) plus the frontend pairing regression, so the client-side re-sort here no longer has an issue to close. This PR carried no lane claim and no review. Branch left in place; reopen with a note on #2563 if it adds something #2609 lacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant