Skip to content

fix(ci): ignore comments after workflow with keys - #2532

Merged
Chris0Jeky merged 2 commits into
mainfrom
issue-2450/release-cache-comment
Sep 6, 2026
Merged

fix(ci): ignore comments after workflow with keys#2532
Chris0Jeky merged 2 commits into
mainfrom
issue-2450/release-cache-comment

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • strip trailing YAML comments before matching a sibling with: key
  • add a regression proving with: # comment remains a block mapping
  • preserve the fail-closed rejection for a real inline with scalar

Verification

ode --test scripts/ci/release-cache-contract.test.mjs — 29 passed

  • git diff --check

This is a CI-09 scanner-only repair; hosted CI on the exact PR head remains the merge gate.

Closes #2450
Refs #2333

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

The connector usage-limit notice is informational, not a review finding. This PR is being checked through the independent coordinator review path; no code action is requested from this notice.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Review (agent half of the ADR-0066 gate; Codex credits exhausted, SC-9): one fresh-context reviewer confirmed stripYamlComment is quote-aware and requires a whitespace-preceded unquoted # (YAML's own rule), so a real inline with: scalar cannot slip past the fail-closed check; the regression fixture discriminates by construction; no real workflow currently contains 'with: #', so this is defensive. Verdict SHIP. LOWs declined (the inline fixture is not valid YAML but the checker is a line scanner; the with-input loop's naive comment strip is pre-existing and fail-closed). CI-control region: parked for the maintainer's review per ADR-0066 / SC-10 — adding to that list.

@Chris0Jeky
Chris0Jeky merged commit 7036b70 into main Sep 6, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 6, 2026
@Chris0Jeky
Chris0Jeky deleted the issue-2450/release-cache-comment branch September 6, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

CI-09 residual: release cache contract reports a false block-mapping violation for 'with: # comment'

1 participant