Derive series labels from series links instead of stale snapshots - #48
Open
tillkruss wants to merge 1 commit into
Open
Derive series labels from series links instead of stale snapshots#48tillkruss wants to merge 1 commit into
tillkruss wants to merge 1 commit into
Conversation
tillkruss
marked this pull request as draft
August 16, 2026 04:14
tillkruss
force-pushed
the
fix/series-title-from-links
branch
from
August 16, 2026 04:15
a906b2c to
467687e
Compare
tillkruss
force-pushed
the
fix/series-title-from-links
branch
from
August 16, 2026 04:19
467687e to
868f3d3
Compare
tillkruss
marked this pull request as ready for review
August 16, 2026 04:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #34.
Series labels come from
Book.SeriesName/SeriesPosition, stamped once at add time and never re-derived — so books show a series in the wrong language, a number borrowed from another series (The Way of Kings→The Cosmere Universe #1, where the1is Stormlight's), or a series on a book that isn't in one. Building Ruddarr for iOS made it worse: a book turns up under several alias series from different sources, and the label can't be matched back to one —gr:135117isThe Cosmere Universein the scalar andThe Cosmerein the links.SeriesBookLinkis reconciled on every refresh, so it becomes authoritative.BookSeriesLabelpicks one link and formatsTitle #Positionfrom it, so both halves always come from the same series; the API,FileNameBuilderand a refresh-time repair all use it. Also exposesseriesType/parentSeriesIdso clients get the hierarchy instead of inferring it.Database Migration
NO. No schema change, but a refresh rewrites existing
Books.SeriesName/SeriesPositionfrom the links — that's what repairs already-added books. Books without links are untouched.How was this tested?
New fixtures in
Chaptarr.Core.Test/Books:BookSeriesLabelFixture,BookResourceSeriesTitleFixture,BookServiceResyncDenormalizedSeriesFieldsFixture.