feat(auth): add manageData operation and time bounds validation to SEP-10 verification#64
Merged
DeFiVC merged 1 commit intoJul 18, 2026
Conversation
…P-10 verification - Require time bounds on challenge transactions (reject TimeoutInfinite) - Validate that the transaction contains the expected manageData operation - Add test coverage for both validation paths
DeFiVC
approved these changes
Jul 18, 2026
Contributor
There was a problem hiding this comment.
Review: Approve
Solid implementation of SEP-10 time bounds and manageData validation.
What looks good:
- Time bounds enforcement (missing +
TimeoutInfiniterejection) prevents replay attacks manageDataoperation validation matchesHOME_DOMAINused increateChallenge- Two new test cases cover both rejection paths cleanly
- PR description is thorough with clear testing evidence and tradeoff notes
- Clean scope — only the auth service and tests touched
CI green, tests pass, code is correct. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
Summary
Strengthen SEP-10 challenge verification by enforcing time bounds and validating the expected
manageDataoperation is present in the signed transaction.Changes
TimeoutInfinite) — prevents replay attackschainlearn.iomanageData operation before accepting itTesting
npm run typecheck— passesnpm run lint— passes (no new warnings)npx vitest run tests/unit/services/sep10-auth.test.ts— 10/10 tests passTradeoffs
StellarSdk.verify()approach for signature verification (ed25519) rather than iterating signatures manuallyHOME_DOMAINconstant (chainlearn.io) as the expected manageData operation name, matchingcreateChallengeOut of scope
Closes #4