Skip to content

openspec: element-space-orbital-filtering — equinoctial GVE + coast-gap-honest filtering (proposal + design + specs + tasks) - #147

Merged
montge merged 1 commit into
developfrom
feature/element-space-orbital-filtering
Jul 17, 2026
Merged

openspec: element-space-orbital-filtering — equinoctial GVE + coast-gap-honest filtering (proposal + design + specs + tasks)#147
montge merged 1 commit into
developfrom
feature/element-space-orbital-filtering

Conversation

@montge

@montge montge commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

OpenSpec change artifacts for element-space-orbital-filtering — the advanced-methods survey's space-accuracy centerpiece (P2), now fully unblocked by the completed propagation tier.

Why

Cartesian ECI covariances go banana-shaped within a fraction of an orbit of coast — the KeplerJ2 EKF's uncertainty turns dishonest exactly when coast prediction matters (gaps, revisit, handover). Equinoctial elements stay near-Gaussian far longer — and with the NEES/ANEES machinery in-tree, that claim gets measured, not cited.

What the change specifies

  • gauss-variational-equations (new): element rates for the stored direct equinoctial set (a, h, k, p, q, λ) under perturbing RSW accelerations from the shared force closures (J2 enters as j2_acceleration alone; two-body is the analytic secular term), sub-stepped RK4 propagation, near-singular domain tests at e ≈ 0 / i ≈ 0, and cross-formulation equivalence against the Cartesian path — both directions, LEO/MEO/eccentric-through-perigee, measured tolerances (the two formulations share only the force closure, so agreement independently validates the transcription)
  • equinoctial-filter-model (new): MotionModel for UKF/CKF with the mean longitude unwrapped in filter state space — periodicity owned by the conversions, so the classic sigma-point wrap bug is structurally impossible (proven at the wrap boundary and over hundreds of accumulated radians); elements→ECI-position measurement mapping; and the payoff demonstration: a seeded Monte-Carlo coast-gap ANEES sweep in thresh-eval where the element filter SHALL remain χ²-consistent at a recorded gap duration where the Cartesian EKF baseline has exited the band, both filters sharing the same physical process-noise assumption for fairness

Key design decisions

  • GVE equations transcribed only from a fetched authority (DSST/Cefola or Vallado), with the Walker modified-equinoctial set as the recorded fallback route if that's what's fetchable
  • No python fixture generator — the in-tree two-formulation check is stronger than a third transcription of the same equations (recorded deliberately)
  • Element-space process noise: leaning RSW-acceleration-PSD mapped through the GVE input matrix so both demonstration filters share one physical Q assumption (open question, resolved at implementation)
  • Out of scope, each recorded: GEqOE, adaptive GMM splitting (rides on this change — its own follow-up), retrograde (i = π), tracker consumption, TLE mean-element filtering

openspec validate --all --strict --no-interactive: 49/49.

🤖 Generated with Claude Code

…ign + specs + tasks)

The advanced-methods survey's space-accuracy centerpiece, unblocked by
the completed propagation tier: Gauss variational equations for the
stored direct equinoctial set (perturbing RSW accelerations from the
shared force closures, two-body secular term analytic), an equinoctial
MotionModel for the UKF/CKF sigma-point machinery with the mean
longitude UNWRAPPED in filter state space (the classic element-filter
wrap bug made structurally impossible, proven at the wrap boundary),
element->ECI-position measurement mapping, cross-formulation
equivalence validation against the Cartesian KeplerJ2 path (both
directions, LEO/MEO/eccentric — the two formulations share only the
force closure), and the falsifiable payoff: a seeded Monte-Carlo
coast-gap ANEES sweep where the element filter SHALL stay inside the
95% chi-squared band at gap durations where the Cartesian EKF has left
it — the banana-covariance folklore, measured. Explicitly deferred:
GEqOE, adaptive GMM splitting (rides on this change), retrograde
singularity, tracker consumption, TLE mean-element filtering.

openspec validate --all --strict --no-interactive: 49/49.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 17, 2026 00:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@montge, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 76d7ca6d-9570-49d3-be64-fa0d241e5058

📥 Commits

Reviewing files that changed from the base of the PR and between 64a077b and b001352.

📒 Files selected for processing (6)
  • openspec/changes/element-space-orbital-filtering/.openspec.yaml
  • openspec/changes/element-space-orbital-filtering/design.md
  • openspec/changes/element-space-orbital-filtering/proposal.md
  • openspec/changes/element-space-orbital-filtering/specs/equinoctial-filter-model/spec.md
  • openspec/changes/element-space-orbital-filtering/specs/gauss-variational-equations/spec.md
  • openspec/changes/element-space-orbital-filtering/tasks.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/element-space-orbital-filtering

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

Copy link
Copy Markdown

@montge
montge merged commit e057b65 into develop Jul 17, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants