Skip to content

feat: revalidateSession for non-rotating authority remint (CEL-1853) - #19

Merged
mong-x merged 1 commit into
mainfrom
mjnong/cel-1853-revalidate
Sep 10, 2026
Merged

feat: revalidateSession for non-rotating authority remint (CEL-1853)#19
mong-x merged 1 commit into
mainfrom
mjnong/cel-1853-revalidate

Conversation

@mong-x

@mong-x mong-x commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds ConcreteAuthStore.revalidateSession and optional revalidatePath (default /auth/revalidate).
  • Single-flights concurrent remints; joins in-flight refresh/adoption; preserves absolute refresh deadline/timer.
  • One ACCESS_TOKEN_EXPIRED fallback to ordinary refresh; no generic 401/403/503/network fallback.
  • Version bump to 0.16.0 (not published by this PR).

Linear

CEL-1853

Test plan

  • npm test (183 passing) including new session-resolution cases
  • npm run typecheck
  • Publish 0.16.0 before importer pin/adoption

Summary by cubic

Adds ConcreteAuthStore.revalidateSession and optional revalidatePath (default /auth/revalidate) so sessions can be reminted without spending the refresh cookie, fixing the session revocation seen on legacy offer Back navigation (CEL-1853). Concurrent remints are single-flight, join in-flight refresh/adoption, and preserve the absolute refresh deadline. Falls back to ordinary refresh only once on ACCESS_TOKEN_EXPIRED; generic 401/403/503/network errors return unauthorized or unavailable without refresh. Bumps @cellarnode/auth to 0.16.0 (not published in this PR).

Written for commit 4d4426a. Summary will update on new commits.

Review in cubic

Additive 0.16.0 API. Concurrent remints single-flight, preserve refresh
deadline, and fall back to refresh only on ACCESS_TOKEN_EXPIRED.
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mong-x
mong-x marked this pull request as ready for review September 10, 2026 12:10
@mong-x
mong-x merged commit 6de0850 into main Sep 10, 2026
2 checks passed
@mong-x
mong-x deleted the mjnong/cel-1853-revalidate branch September 10, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant