reducing memory usage on OU TDE notebook - #326
Conversation
|
maybe this closes #317 ? |
yes, we should try it, I'm pushing directly to this branch |
bsipocz
left a comment
There was a problem hiding this comment.
I suppose we should try the rendering, hopefully this will be enough
| The two plotting functions then compile these measurements into time-ordered plots showing how the observed flux evolves across multiple visits, providing a first look at temporal variability that could signal transient activity or host-galaxy changes. | ||
|
|
||
| ```{code-cell} ipython3 | ||
| --- |
bsipocz
left a comment
There was a problem hiding this comment.
Trying to build on again, minor fix for the install cell
|
I started noticing new issues in CI, namely that we run out of disk space when we run all the notebooks. I don't think right now that you can or should do much about it in the individual notebook level. xref #333 |
74dc4ec to
0668065
Compare
|
rebased to retrigger CI |
|
The test failures are consistently present, but most likely are not related to the changes in this PR as I saw them in #335. I'm not sure of the preference if we want to include that in this PR, too or want to fix them separately. |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0668065 to
b5f4a21
Compare
|
@bsipocz I tried again to get this one to pass. I think this is failing now due to a different notebook. If it looks ok to you, please merge. |
bsipocz
left a comment
There was a problem hiding this comment.
CI looks all good, this notebooks executes without issues and the one big HTML build doesn't seem to run into memory issues any more either, the failure is totally unrelated.
Thank you!
This PR reduces memory usage in the TDE light curve notebook to address CI failures likely caused by memory constraints. It does not effect the science or goals of the notebook
Changes: