test: add Pest v1 security test infrastructure#55
Merged
TheWitness merged 4 commits intoJul 24, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds initial Pest v1-based “security” test scaffolding for the Cacti audit plugin, aiming to catch structural regressions and certain unsafe patterns via lightweight static checks.
Changes:
- Added a Pest bootstrap that stubs key Cacti framework functions/constants for isolated test execution.
- Added security-oriented Pest tests for
setup.phpstructure, prepared-statement usage, and PHP 7.4 syntax compatibility. - Added
tests/Pest.phpto load the bootstrap.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/bootstrap.php | Provides stubbed Cacti functions/constants to allow tests to run without a full Cacti install. |
| tests/Pest.php | Pest entrypoint that loads the test bootstrap. |
| tests/Security/SetupStructureTest.php | Verifies setup.php contains required plugin lifecycle functions and version keys. |
| tests/Security/PreparedStatementConsistencyTest.php | Attempts to enforce exclusive usage of prepared DB helpers in core plugin files. |
| tests/Security/Php74CompatibilityTest.php | Scans for common PHP 8.0+ syntax/features in core plugin files. |
somethingwithproof
force-pushed
the
test/security-test-infrastructure
branch
from
July 14, 2026 10:46
9ea4ea3 to
4575e4d
Compare
browniebraun
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the Pest security test infrastructure into its own PR as requested.