Add support for PHP 8.5 images - #200
Merged
Merged
Conversation
ikidnapmyself
approved these changes
Jul 28, 2026
The php85-mysql57 image is not pullable: its tag and manifest resolve, but 9 of its 13 layer blobs are missing from the registry, so CI died with "unknown blob" before running a single test. Magento 2.4.9 -- the first release compatible with PHP 8.5, already pinned for this row -- only supports MySQL 8.4, so MySQL 5.7 was never the right database here to begin with. Parameterize the mysql part of the image name and point the 8.5 row at php85-mysql84, which is complete in the registry. All other PHP versions keep using mysql57.
…tainer The commands in this script run as root inside the Hypernode container, while the rsync that copies the installed Magento to the deploy container authenticates over SSH as app. On Magento 2.4.9 that combination breaks: var/cache/symfony ends up unreadable for app, so rsync fails with opendir "/data/web/magento2/var/cache/symfony" failed: Permission denied (13) rsync error: some files/attrs were not transferred (code 23) Chowning the tree to app first makes the ownership match the SSH user -- which is also how a real Hypernode looks, where app owns the application. 2.4.6-p10 and 2.4.8 do not hit this, so only the PHP 8.5 row was failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.