fix: keep interactive cursor visible under NO_COLOR#350
Closed
Solaris-star wants to merge 1 commit into
Closed
Conversation
crossterm still emits empty SGR color wrappers under NO_COLOR that collapse to CSI 0 m and reset attributes, cancelling REVERSED after ratatui paints it. Use UNDERLINED for the selected line when NO_COLOR is set so the cursor remains visible. Fixes Byron#238.
Owner
|
For me this doesn't do anything, and 
The bar isn't visible, because this fix suffers from the same issue as before: the style is reset immediately. |
Owner
|
Superseded by #351 . |
Byron
added a commit
that referenced
this pull request
Jul 20, 2026
fix: only strip colors when `NO_COLOR` is enabled (#350)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
NO_COLOR, the selected entry indua iwas invisible because REVERSED was reset by empty SGR color sequences from crossterm. Prefer UNDERLINED (and keep BOLD when focused) whenNO_COLORis set.Fixes #238.