Skip to content

Suggestion of features + fixes#349

Closed
gabrielfalcao wants to merge 1 commit into
Byron:mainfrom
gabrielfalcao:main
Closed

Suggestion of features + fixes#349
gabrielfalcao wants to merge 1 commit into
Byron:mainfrom
gabrielfalcao:main

Conversation

@gabrielfalcao

Copy link
Copy Markdown
  • Interactive Mark: switch between split horizontal and vertial via hotkey (uppercase) "U"
  • Standard Ouput after quitting Interactive Mark: print absolute paths as opposed to relative paths.
  • Aggregate Output: only print colored output when stdout supports just so.

This squashed commit has been bisected when the upstream head is fa5cd45 and the last common ancestor is 63b129b

The following commits which might or might not remain in the reflog are:

commit 876a54f
commit 529e0ea
commit 169eade
commit 83d987d
commit a3a682d
commit f8deb24
commit 140bf8d
commit b80ad42
commit 19e1e17

Conflicts:
Cargo.lock
Cargo.toml
src/interactive/app/state.rs
src/interactive/widgets/entries.rs
src/interactive/widgets/help.rs
src/interactive/widgets/main.rs
src/main.rs

- Interactive Mark: switch between split horizontal and vertial via hotkey (uppercase) "U"
- Standard Ouput after quitting Interactive Mark: print absolute paths as opposed to relative paths.
- Aggregate Output: only print colored output when stdout supports just so.

This squashed commit has been bisected when the upstream head is
fa5cd45 and the last common ancestor
is 63b129b

The following commits which might or might not remain in the reflog are:

commit 876a54f
commit 529e0ea
commit 169eade
commit 83d987d
commit a3a682d
commit f8deb24
commit 140bf8d
commit b80ad42
commit 19e1e17

Conflicts:
	Cargo.lock
	Cargo.toml
	src/interactive/app/state.rs
	src/interactive/widgets/entries.rs
	src/interactive/widgets/help.rs
	src/interactive/widgets/main.rs
	src/main.rs
@Byron

Byron commented Jul 15, 2026

Copy link
Copy Markdown
Owner

I don't know what happened here, but this is too sloppy and strange.

@Byron Byron closed this Jul 15, 2026
@gabrielfalcao

Copy link
Copy Markdown
Author

I don't know what happened here, but this is too sloppy and strange.

Just for the record, no A.I. involved, any sloppyness here is my own 🥂
No harm no foul, thanks for creating this amazing open source tool. I use it in a daily basis and being able to build my own fork is a factor of two things: This project being open source AND your source code being very easy to navigate, understand and modify.

You l33t, kudos!

@Byron

Byron commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Hehe, thanks! I wasn't even aware that calling something "sloppy" might be insulting, so my apologies for this. Nonetheless, if you want to upstream changes, it's certainly better to keep them small and well bounded.

Aggregate Output: only print colored output when stdout supports just so.

This seems like a bugfix that should be upstreamed.

Standard Ouput after quitting Interactive Mark: print absolute paths as opposed to relative paths.

I think this would make it more universally useful, and easier to use in consuming programs so let's have it, in the same PR is fine, but a separate commit.

Interactive Mark: switch between split horizontal and vertial via hotkey (uppercase) "U"

Let's see how it looks in a video - this could be the last PR. Generally I like here that ultimately it removes code, which makes this PR desirable in principle. With a little more care we should be able to get everything merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants