Notify after interactive work when unfocused#348
Merged
Conversation
Byron
force-pushed
the
notify-when-done-and-unfocussed
branch
2 times, most recently
from
July 14, 2026 13:31
cccac5e to
40b3ba2
Compare
Byron
marked this pull request as ready for review
July 14, 2026 13:31
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40b3ba272e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Interactive scans, refreshes, deletion, and trash operations can take long enough that users leave the terminal, but dua previously had no way to signal completion without exiting the TUI. Track terminal focus events and emit sanitized OSC 777 notifications only when the terminal is unfocused. Include concise entry, byte, duration, and error statistics, and add a notifications config section whose scan_finished and delete_finished switches default to true. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Byron
force-pushed
the
notify-when-done-and-unfocussed
branch
from
July 14, 2026 13:36
40b3ba2 to
d800f22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.
Everything below this line was generated by Codex GPT-5.
Created by Codex on behalf of Byron. Byron will review before this is ready to merge.
Fixes #347
Summary
[notifications]withscan_finishedanddelete_finished, both enabled by default; accept the authoritative comment spellingcan_finishedas an aliasValidation
cargo test --workspace --all-features -- --skip it_can_handle_ending_traversal_reaching_top_but_skipping_levels --skip it_can_handle_ending_traversal_without_reaching_the_topcargo test --workspace --no-default-featurescargo check --workspace --all-featurescargo clippy --lib --all-features -- -D warningsThe unfiltered all-feature suite has two pre-existing filesystem-dependent fixture-size assertion failures; all other tests pass.
Review
Codex commit review identified and drove fixes for focus changes during blocking deletion/trash work, bounded input handling, and partial-deletion statistics. The final review concern about dropping input beyond the bounded queue is an intentional safety behavior during periods when the TUI cannot consume events, avoiding stale destructive command replay while focus changes remain independently coalesced.