Skip to content

BI-2959: Use External UID Source for Germplasm External UID References#480

Merged
HMS17 merged 2 commits into
developfrom
feature/BI-2959
Jul 20, 2026
Merged

BI-2959: Use External UID Source for Germplasm External UID References#480
HMS17 merged 2 commits into
developfrom
feature/BI-2959

Conversation

@humsika

@humsika humsika commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Description

Story: BI-2959

This PR updates the frontend germplasm External UID display logic to match the BI-2959 backend behavior.

External UID is now resolved using the canonical external reference source "External UID" instead of the germplasm Source / seedSource value. This fixes External UID display in:

  • germplasm import preview
  • germplasm list / all germplasm views

This PR also adds frontend unit tests for the updated External UID lookup behavior.

Dependencies

bi-web: feature/BI-2959
bi-api: feature/BI-2959

Testing

Verified manually:

  • germplasm import preview displays External UID when both Source and External UID are present
  • germplasm import preview displays External UID when Source is blank and External UID is present
  • germplasm import preview does not display External UID when no canonical External UID reference exists
  • committed germplasm UI resolves External UID from the canonical "External UID" reference source

Verified with unit tests:

  • externaluid.spec.ts
  • germplasmutils.spec.ts

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

…lay the value and added unit tests for canonical External UID display.
@humsika
humsika requested a review from HMS17 July 17, 2026 15:22

@HMS17 HMS17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper External UIDs display locally and code looks good!

@HMS17
HMS17 merged commit 83179e5 into develop Jul 20, 2026
1 check passed
@HMS17
HMS17 deleted the feature/BI-2959 branch July 20, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants