engine: fix crates.io release from tag checkouts - #4670
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
📝 WalkthroughWalkthroughThe release workflow now permits ChangesRelease workflow updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: 🔵 Low · up to This change restores tag-triggered publication of the four Rust SDK crates while retaining the existing release gates. Because repository tag protection and release-environment authorization are not confirmed here, owners should verify that only trusted release actors can trigger matching tags; the PR is otherwise mergeable with that follow-up. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d022a9d58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@coderabbitai review |
|
Summary
HEADcreated by tag-triggeredactions/checkoutEvidence
The canonical 0.226.2 crates job failed before publishing with
cannot release from branch HEAD. cargo-release 1.1.5 exposes--allow-branch, and an exact detached-HEAD dry run confirmed--allow-branch HEADselects all four Rust SDK crates.The one-off recovery run is preserved at https://github.com/BoundaryML/baml/actions/runs/33477729574. Its provenance and absence checks passed, but its non-publishing verification plan stopped because the runner did not have
protoc; the credentialed publish step never ran and all four 0.226.2 crate URLs remain 404. No retry was submitted.Validation
actionlint .github/workflows/release.yml .github/workflows/publish-crates-0.226.2.ymlgit diff --check--allow-branch HEAD