Remove defunct Ty variants and rename BuiltinUnknown -> Unknown - #4603
Merged
Conversation
Now that we have proper inference variables they are unused.
This is NOT the top-type `unknown` which is (currently) named `Ty::BuiltinUnknown`. It was formerly and inference-recoverable error sentinel but is no longer needed now that we have a proper rust-like hybrid obligation inference system.
2kai2kai2
marked this pull request as ready for review
August 26, 2026 18:26
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2kai2kai2
enabled auto-merge
August 26, 2026 18:26
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (14)
📒 Files selected for processing (100)
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (14)
📒 Files selected for processing (100)
📝 WalkthroughWalkthroughThe PR makes ChangesType Sentinel Migration
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested reviewers: Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Now that the defunct "Unknown" error-sentinel is gone, the `unknown` type can be called `Unknown` internally as well.
2kai2kai2
force-pushed
the
kai/ty_family_infer
branch
from
August 26, 2026 18:39
ff42735 to
634dc97
Compare
It probably shouldn't even be checked in but for now
Binary size checks failed❌ 2 violations · ✅ 5 passed
Details & how to fixViolations:
Add/update baselines:
[artifacts.baml-cli]
file_bytes = 83014656
stripped_bytes = 83014656
gzip_bytes = 27869997
[artifacts.packed-program]
file_bytes = 30901618
gzip_bytes = 10742068Generated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ty::EvolvingListandTy::EvolvingMapwhich are unnecessary now that we have proper inference variablesTy::Unknownwhich is unnecessary now with the new inference systemSelfunknownfromTy::BuiltinUnknowntoTy::UnknowninternallySummary by CodeRabbit
unknown, omitted type annotations, unresolved inference, and compiler errors.unknown, lists, maps, interfaces, and generic operations.