fix(csharp): align release verifier with generated surface - #4446
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe C# CSV resource test removes iterator, typed decoding, and raw-record assertions. It now checks headers, ChangesCSV resource test updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change updates the C# release verifier to match the generated API surface while retaining coverage for supported methods and fields. The targeted test and Release build are provided, and no actionable merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Binary size checks passed✅ 7 passed
Generated by |
|
Attempt 2 of the 0.17.0 release run confirmed the same deterministic failure: https://github.com/BoundaryML/baml/actions/runs/31857280879/attempts/2?pr=4446 The phase-12 consumer fails to compile because generated CsvReader has no Iter/Next and generated CsvRows has no Iter/Next/NextAsync. This PR removes those stale interface-implementation calls and has already passed the exact phase-12 native integration test locally. |
Summary
baml.time.*#4366, which intentionally omits methods inherited through BAML interface implementations.Root cause
The phase-12 fixture is normally ignored because of B-1059, but the production full-surface package verifier compiles and runs it. Its stale calls to CsvReader.Iter/Next and CsvRows.Iter/Next no longer compile after #4366 removed interface-implementation methods from generated class method collections.
Validation
Release follow-up
After this merges and post-merge canary CI succeeds, 0.17.0 must be dispatched from the new immutable baml-language source tag. This PR does not publish or dispatch the release.
Summary by CodeRabbit