fix(DockView): throw exception when dispose

[ArgoZhang]

Link issues

fixes #999

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

• Stop saving DockView configuration during component disposal to prevent errors when disposing.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the DockView disposal behavior to avoid calling configuration persistence during component teardown, preventing an exception on dispose.

Sequence diagram for updated DockviewComponent.dispose behavior

sequenceDiagram
    participant Caller
    participant DockviewComponent
    participant Group
    participant BaseDispose as dispose

    Caller->>DockviewComponent: dispose()
    activate DockviewComponent
    loop for each group
        DockviewComponent->>Group: mutationObserver.disconnect()
    end
    DockviewComponent->>BaseDispose: dispose.call(this)
    deactivate DockviewComponent

Loading

File-Level Changes

Change	Details	Files
Update DockviewComponent.dispose to stop persisting configuration during disposal, preventing errors when the component is torn down.	Remove the call that saves DockView configuration from the custom dispose implementation Keep the existing logic that disconnects mutation observers for each group before delegating to the original dispose function	src/components/BootstrapBlazor.DockView/wwwroot/js/dockview-extensions.js

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#999	Fix the DockView dispose behavior so that disposing a DockView instance no longer throws an exception.	✅

Possibly linked issues

• #(not specified): PR removes the saveConfig call in DockView.dispose, fixing the disposal-time exception described in the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider adding a short inline comment explaining why saveConfig(this) is intentionally not called during dispose (e.g., disposal-time errors), so future maintainers don’t reintroduce it inadvertently.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider adding a short inline comment explaining why `saveConfig(this)` is intentionally not called during `dispose` (e.g., disposal-time errors), so future maintainers don’t reintroduce it inadvertently.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}