Update visual regression baselines for the QR badge rework (BL-16638) - #8134
Merged
Conversation
BL-16370 changed how the back cover renders but landed without regenerating the reference images, so the nightly visual regression suite has been red since. This regenerates the 22 baselines it affected: 10 whole-book preview captures and 12 bloom-player page captures. What changed in the renders, all of it BL-16370's intended design: - The "Made with Bloom" badge caption becomes "More books in <language> language:" over a BloomLibrary.org/language:<tag> link, and the QR code re-encodes to that language-specific address rather than the site root. - Local-Community swaps the Bloom tulip over "Local" for a gift box over "Bloom Local", gains the QR badge on its back cover (which it did not carry before), and rewrites its back-cover subscription paragraph, which also loses the white box it used to sit in. Both rendering paths needed updating. The preview and bloom-player render the book separately, so each has its own baselines, and the player ones had never been compared even once since BL-16370: a case captures its preview first and every comparison throws on failure, so a stale preview aborted the case before any player page was captured. Only after accepting the preview baselines did the player set become visible. All 84 images now compare and match (12 of 12 cases pass). Deliberately not touched: A5 theme-rounded-border-ebook-player-p1. It differs under a more sensitive threshold, but pixelmatch counts zero differing pixels at the threshold the suite asserts on, so it is sub-threshold anti-aliasing jitter rather than a real change; rewriting that baseline would risk baking in run-to-run noise. The five 16x9 preview counts reproduced the CI run exactly (6307 / 91808 / 6307 / 6307 / 6272), confirming these locally generated baselines match what the Release build in CI renders. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
[Claude Opus 5 (1M context)] Consulted Devin on 2026-07-30 16:38 USMST up to commit Devin's review completed for that commit and was clean — no bugs, no Investigate flags, no informational items. Unsurprising for a change that contains no code: the diff is 22 binary reference images and the source tree is byte-identical to CI ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the 22 visual-regression baselines that BL-16370's QR badge rework invalidated. Reference images only — no source changes (
git diff --name-only origin/master..HEADis 22 PNGs), so the code under test is byte-identical tomaster.Why the suite was red
BL-16370 changed how the back cover renders and landed without regenerating baselines, so the nightly has failed since. Every change below is that ticket's intended design:
BloomLibrary.org/language:<tag>link, and the QR code re-encodes to that language-specific address rather than the site root.Both rendering paths, and why half of this was invisible
The preview and bloom-player render the book separately, so each has its own baselines: 10 whole-book preview captures and 12 bloom-player page captures.
The player ones had never been compared even once since BL-16370. A case captures its preview first, then walks player pages in order, and every comparison throws on failure — so a stale preview aborted each case before any player page was captured, and a stale player page hid every page after it. Only after the preview baselines were accepted did the player set become visible at all. Two of them (both Local-Community back covers) had never been captured by any run in this suite's history.
To avoid discovering this one layer per run, the comparison was made non-fatal for a single local diagnostic run so all 84 images were captured at once; that change was reverted before committing (
index.spec.tsis untouched in this PR).Deliberately not updated
A5 Portrait / theme-rounded-border-ebook-player-p1differs by 51 pixels under a more sensitive threshold, but pixelmatch counts zero differing pixels at the threshold the suite asserts on. That is sub-threshold anti-aliasing jitter, not a real change; rewriting the baseline would risk baking run-to-run noise into it.Verification
Ref: https://issues.bloomlibrary.org/youtrack/issue/BL-16638
Devin review
This change is