Update esbuild.config.mjs - #16
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the header documentation in esbuild.config.mjs (version, summary, description, dates) to reflect ESLint configuration for CodePulse, with no functional changes to the build logic. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The updated file header now describes this as an ESLint configuration, but the file still contains esbuild bundling logic; please align the summary/description with the actual purpose of the module.
- The version was changed from 2.0.0 back to 1.0.0 and the @SInCE date is set in the future; double-check that the versioning and dates reflect the real release history and timeline.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The updated file header now describes this as an ESLint configuration, but the file still contains esbuild bundling logic; please align the summary/description with the actual purpose of the module.
- The version was changed from 2.0.0 back to 1.0.0 and the @since date is set in the future; double-check that the versioning and dates reflect the real release history and timeline.
## Individual Comments
### Comment 1
<location path="esbuild.config.mjs" line_range="8-11" />
<code_context>
* @license MIT
*
- * @summary esbuild configuration for bundling the VS Code extension.
+ * @summary ESLint configuration for CodePulse.
*
* @description
- * Bundles the extension code, but keeps runtime dependencies (web-tree-sitter,
- * tree-sitter languages, sql.js, jspdf) as external modules since they need
- * their WASM files to be available at runtime.
- *
- * Runtime dependencies are shipped in the `deps/` directory (not node_modules)
- * because pnpm's symlinked node_modules are incompatible with vsce packaging.
- * The depsRewrite plugin rewrites bare imports of these packages to resolve
- * from `../deps/<package>` relative to the output file in `out/`.
+ * Strict ESLint configuration for CodePulse that ignores runtime dependencies.
*
* @since 09/07/2026
</code_context>
<issue_to_address>
**issue:** Header summary/description no longer matches the role of this file.
The header now describes an ESLint config, but this file is an esbuild bundling config. Please update the summary/description to accurately reflect the module’s actual purpose so future maintainers and any tooling using these annotations aren’t misled.
</issue_to_address>
### Comment 2
<location path="esbuild.config.mjs" line_range="11" />
<code_context>
- * because pnpm's symlinked node_modules are incompatible with vsce packaging.
- * The depsRewrite plugin rewrites bare imports of these packages to resolve
- * from `../deps/<package>` relative to the output file in `out/`.
+ * Strict ESLint configuration for CodePulse that ignores runtime dependencies.
*
* @since 09/07/2026
</code_context>
<issue_to_address>
**suggestion:** Description no longer reflects behavior of the esbuild configuration.
The previous description correctly explained the bundling behavior and handling of externals, while the new one is about ESLint and seems unrelated. Please restore or rewrite the header so it accurately documents this build configuration (externals, output path, etc.).
Suggested implementation:
```javascript
*
* @description
* Esbuild configuration for the CodePulse VS Code extension that:
* - Works around pnpm's symlinked node_modules which are incompatible with vsce packaging.
* - Treats selected runtime dependencies as externals and rewrites their bare imports
* via the `depsRewrite` plugin to resolve from `../deps/<package>` relative to `out/`.
* - Emits bundled extension code into the `out/` directory for packaging.
*
* @since 09/07/2026
* @updated 13/07/2026
*/
```
```javascript
// ---------- IMPORTS
import esbuild from 'esbuild';
build().catch((error) => {
```
If the configuration currently uses different plugin names, externals handling, or output paths than described here, you should:
1. Adjust the bullet points in the `@description` to match the actual plugin names (e.g. if `depsRewrite` has been renamed).
2. Update the mention of `../deps/<package>` and `out/` to the real paths configured in this file (e.g. `dist/`, different deps folder).
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+8
to
+11
| * @summary ESLint configuration for CodePulse. | ||
| * | ||
| * @description | ||
| * Bundles the extension code, but keeps runtime dependencies (web-tree-sitter, | ||
| * tree-sitter languages, sql.js, jspdf) as external modules since they need | ||
| * their WASM files to be available at runtime. | ||
| * | ||
| * Runtime dependencies are shipped in the `deps/` directory (not node_modules) | ||
| * because pnpm's symlinked node_modules are incompatible with vsce packaging. | ||
| * The depsRewrite plugin rewrites bare imports of these packages to resolve | ||
| * from `../deps/<package>` relative to the output file in `out/`. | ||
| * Strict ESLint configuration for CodePulse that ignores runtime dependencies. |
There was a problem hiding this comment.
issue: Header summary/description no longer matches the role of this file.
The header now describes an ESLint config, but this file is an esbuild bundling config. Please update the summary/description to accurately reflect the module’s actual purpose so future maintainers and any tooling using these annotations aren’t misled.
| * because pnpm's symlinked node_modules are incompatible with vsce packaging. | ||
| * The depsRewrite plugin rewrites bare imports of these packages to resolve | ||
| * from `../deps/<package>` relative to the output file in `out/`. | ||
| * Strict ESLint configuration for CodePulse that ignores runtime dependencies. |
There was a problem hiding this comment.
suggestion: Description no longer reflects behavior of the esbuild configuration.
The previous description correctly explained the bundling behavior and handling of externals, while the new one is about ESLint and seems unrelated. Please restore or rewrite the header so it accurately documents this build configuration (externals, output path, etc.).
Suggested implementation:
*
* @description
* Esbuild configuration for the CodePulse VS Code extension that:
* - Works around pnpm's symlinked node_modules which are incompatible with vsce packaging.
* - Treats selected runtime dependencies as externals and rewrites their bare imports
* via the `depsRewrite` plugin to resolve from `../deps/<package>` relative to `out/`.
* - Emits bundled extension code into the `out/` directory for packaging.
*
* @since 09/07/2026
* @updated 13/07/2026
*/ // ---------- IMPORTS
import esbuild from 'esbuild';
build().catch((error) => {If the configuration currently uses different plugin names, externals handling, or output paths than described here, you should:
- Adjust the bullet points in the
@descriptionto match the actual plugin names (e.g. ifdepsRewritehas been renamed). - Update the mention of
../deps/<package>andout/to the real paths configured in this file (e.g.dist/, different deps folder).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Documentation: