fix(test): LAST_SHIPPED stays 17 until 7.16 actually ships - #51
Merged
Conversation
My own U5 update asserted STORAGE_VERSION_LAST_SHIPPED == 20, which is wrong in
the specific way storage.h warns about two lines above the constant:
"Bump this baseline when a release ships, in the release commit, never to
make a build compile: lowering it is the exact edit that turns every
upgrade in the field into a silent wipe."
LAST_SHIPPED is the high-water mark of what is IN THE FIELD, not of what sits
in the tree. 7.15 shipped V17; 7.16 has shipped nothing. Asserting 20 would
have forced the next person to raise the baseline to make the test pass -- the
edit the gate exists to prevent, arrived at by way of the gate itself.
The compile-time assert only requires STORAGE_VERSION >= LAST_SHIPPED, and
20 >= 17 holds, so the raise was never needed. It moves in the release commit
that tags 7.16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My own U5 update asserted
STORAGE_VERSION_LAST_SHIPPED == 20. That is wrong in the specific waystorage.hwarns about two lines above the constant:LAST_SHIPPEDis the high-water mark of what is in the field, not what sits in the tree. 7.15 shipped V17; 7.16 has shipped nothing. Asserting 20 would have forced the next person to raise the baseline to make the test pass — the edit the gate exists to prevent, arrived at by way of the gate itself.The compile-time assert only needs
STORAGE_VERSION >= LAST_SHIPPED, and20 >= 17holds, so the raise was never required. It moves in the release commit that tags 7.16.