feat(report): catalog KKSOLSW1, and make a skip fail where the feature exists - #45
Merged
Merged
Conversation
…e exists
R-4.1 -- provider-attested Solana lookup-table accounts -- had four tests and
ZERO presence in the atlas. It is a headline 7.15 feature, and an auditor
reading the PDF would have found no evidence it works, which is the exact
failure the atlas exists to prevent.
S26-S29 catalog them:
S26 attested accounts are shown AND the blind-sign warning survives
S27 a signature that does not verify changes nothing
S28 an attestation cannot be replayed onto another transaction
S29 with no signer loaded, a well-formed attestation is inert
S26 declares screens, so the filter picks it up and the screenshot leg captures
it -- the atlas is the single source of truth for OLED capture, so cataloguing
it is what makes the evidence exist.
The Solana section background now states the gap this closes. It described the
44-character address fix and stopped, which left S24 ("v0 with address-table
lookups requires AdvancedMode") reading like a design choice rather than the
open problem it is: the device cannot resolve a table it has never seen, so it
routed those transactions to the blind-sign gate and SIGNED ACCOUNTS IT NEVER
SHOWED. S26-S29 are the answer, and the section now says so.
MUST_RUN_MODULES becomes version-aware. It was a flat set, so listing a
7.15-only module would have failed every older-firmware run for a feature that
legitimately cannot exist yet -- module -> the version from which a skip
becomes a failure. test_msg_solana_lut_attestation is listed at 7.15.0: all
four gate on requires_message('LoadClearsignSigner'), so if provider loading
regressed they would all skip and the report would certify a feature it never
exercised. Silence becomes a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R-4.1 — provider-attested Solana lookup-table accounts — had four tests and zero presence in the atlas. It's a headline 7.15 feature, and an auditor reading the PDF would have found no evidence it works. That's the exact failure the atlas exists to prevent.
S26–S29catalog them:S26 declares screens, so the filter picks it up and the screenshot leg captures it — the atlas is the single source of truth for OLED capture, so cataloguing it is what makes the evidence exist.
The Solana background now states the gap this closes. It described the 44-character address fix and stopped, which left S24 ("v0 with address-table lookups requires AdvancedMode") reading like a design choice rather than the open problem it is: the device cannot resolve a table it has never seen, so it routed those transactions to the blind-sign gate and signed accounts it never showed.
MUST_RUN_MODULESbecomes version-aware. It was a flat set, so listing a 7.15-only module would have failed every older-firmware run for a feature that legitimately cannot exist yet. Now module → the version from which a skip becomes a failure.test_msg_solana_lut_attestationis listed at 7.15.0: all four gate onrequires_message('LoadClearsignSigner'), so if provider loading regressed they'd all skip and the report would certify a feature it never exercised.