fix(report): stop declaring screens seven tests cannot draw - #42
Merged
Conversation
The report's own gate was failing:
screenshot audit FAILED -- declared screens with no capture:
test_msg_ethereum_getaddress::test_ethereum_getaddress
test_msg_ripple_get_address::test_ripple_get_address
test_msg_ethereum_clear_signing::test_valid_metadata_returns_verified
test_msg_solana_getaddress::test_solana_get_address
test_msg_tron_getaddress::test_tron_get_address
test_msg_ton_getaddress::test_ton_get_address
test_msg_zcash_orchard::test_fvk_reference_vectors
None of them is a missing capture. Each entry declared a screen the test can
never produce:
- the five *getaddress* tests return the address ON THE WIRE. The drawn
address is the *show_address* sibling, which is separately catalogued and
does capture it (S3b, T3b, N2b, B4).
- test_valid_metadata_returns_verified asserts the VERIFIED classification
before anything is rendered.
- test_fvk_reference_vectors is reference-vector arithmetic compared in
memory.
So the declarations were wrong, not the runs. Emptied, and each carries a line
saying why it is empty and where the screen actually lives -- an empty list is
already meaningful in this catalog ("refusal paths draw nothing, and their
evidence is the Failure on the wire plus the ABSENCE of a ButtonRequest"), so
it must read as intent rather than omission.
This matters beyond tidiness. The audit is a release gate, and a gate that
fails for a reason nobody can fix gets ignored -- and an ignored gate is the
one that misses the real defect later. It now passes:
screenshot audit: every declared screen was captured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report's own gate was failing:
None is a missing capture. Each entry declared a screen the test can never produce:
getaddresstests return the address on the wire; the drawn address is theshow_addresssibling, separately catalogued and capturing it (S3b, T3b, N2b, B4);test_valid_metadata_returns_verifiedasserts the VERIFIED classification before anything is rendered;test_fvk_reference_vectorsis reference-vector arithmetic compared in memory.So the declarations were wrong, not the runs. Emptied, each with a line saying why it is empty and where the screen actually lives — an empty list already means something in this catalog, so it must read as intent rather than omission.
This matters beyond tidiness. The audit is a release gate, and a gate that fails for a reason nobody can fix gets ignored — and an ignored gate is the one that misses the real defect later.