regen(pb2): messages_solana with the pinned image, for the KKSOLSW1 tags - #41
Merged
Conversation
Regenerated with docker_build_pb.sh's toolchain -- kktech/firmware:v8, which
carries protoc 3.5.1 -- so the output is the same old-style generated code as
every other *_pb2.py in this package:
DESCRIPTOR = _descriptor.FileDescriptor(...)
That style is not incidental. The CI test container is Alpine 3.8 / Python
3.6.9, and its protobuf runtime cannot load modern descriptor_pool generated
code; a modern-protoc regeneration of this one file took down
python-integration-tests, and generate-test-report with it, on every alpha run
until it was reverted.
Adds the SolanaSignTx lut_account / lut_signature / lut_signer_key_id fields
(tags 5-7) so the KKSOLSW1 tests can construct the message.
Verified against the emulator: KKSOLSW1 suite 4/4, full pyk 632 passed /
25 skipped / 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated with
docker_build_pb.sh's toolchain —kktech/firmware:v8, which carries protoc 3.5.1 — so the output is the same old-style generated code as every other*_pb2.pyhere:That style is not incidental. The CI test container is Alpine 3.8 / Python 3.6.9, and its protobuf runtime cannot load modern
descriptor_poolgenerated code. A modern-protoc regeneration of this one file took downpython-integration-tests— andgenerate-test-reportwith it — on every alpha run until it was reverted.Adds
SolanaSignTx.lut_account/lut_signature/lut_signer_key_id(tags 5–7) so the KKSOLSW1 tests can construct the message.Verified against the emulator: KKSOLSW1 4/4, full pyk 632 passed / 25 skipped / 0 failed.