test: gate the bitcoin-only suite on the bitcoin-only product - #34
Merged
Conversation
Adds requires_bitcoinOnly(), the inverse of requires_fullFeature(), and applies
it in test_msg_bitcoin_only_variant.setUp().
The file describes the BITCOIN-ONLY product, but CI points the pyk suite at the
full emulator image, so it ran there too. Most of it passes either way; the
OP_RETURN test does not, because on the multi-chain build the same transaction
decodes a THORChain memo and draws more screens ([3,3,3,3,3,8] against the
bitcoin-only [3,3,8]). That is a category error, not a finding.
The guard could not be written until now, and the file's own docstring says so:
variant_getName() answered "Emulator" for BOTH products, so a bitcoin-only
emulator was indistinguishable from a full one. keepkey-firmware #495 fixed
that, and this is the first thing it buys.
Measured after the guard:
full emulator 620 passed, 33 skipped, 0 failed
bitcoin-only emu 11 passed, 0 skipped, 0 failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
requires_bitcoinOnly()— the inverse ofrequires_fullFeature()— and applies it intest_msg_bitcoin_only_variant.setUp().The file describes the bitcoin-only product, but CI points the pyk suite at the full emulator image, so it ran there too. Most of it passes either way; the OP_RETURN test does not, because on the multi-chain build the same transaction decodes a THORChain memo and draws more screens (
[3,3,3,3,3,8]vs bitcoin-only[3,3,8]). Category error, not a finding.The guard could not be written until now, and the file's own docstring says so:
variant_getName()answered"Emulator"for both products. keepkey-firmware #495 fixed that, and this is the first thing it buys.