Skip to content

test(uniswap): run the liquidity tests on the emulator instead of skipping them #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BitHighlander merged 1 commit into from
Aug 21, 2026
Merged

test(uniswap): run the liquidity tests on the emulator instead of skipping them #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions tests/test_msg_ethereum_erc20_uniswap_liquidity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,6 @@ class TestMsgEthereumUniswaptxERC20(common.KeepKeyTest):

def test_sign_uni_approve_liquidity_ETH(self):
self.requires_fullFeature()
if self.client.features.firmware_variant[0:8] == "Emulator":
# Approving an UNKNOWN token contract (the FOX pool, not in the
# token table) does not complete on the emulator — same limitation
# as test_sign_uni_add_liquidity_ETH below. Known-token approves
# (test_msg_ethereum_erc20_approve) pass here; on-device this path
# is exercised by the app. Pre-existing, unrelated to clear-signing.
self.skipTest("Skip until emulator issue resolved")
self.requires_firmware("7.1.0")
self.setup_mnemonic_nopin_nopassphrase()

Expand All @@ -62,9 +55,6 @@ def test_sign_uni_approve_liquidity_ETH(self):

def test_sign_uni_add_liquidity_ETH(self):
self.requires_fullFeature()
if self.client.features.firmware_variant[0:8] == "Emulator":
self.skipTest("Skip until emulator issue resolved")
return
self.requires_firmware("7.1.0")
self.setup_mnemonic_nopin_nopassphrase()

Expand Down Expand Up @@ -94,9 +84,6 @@ def test_sign_uni_add_liquidity_ETH(self):

def test_sign_uni_remove_liquidity_ETH(self):
self.requires_fullFeature()
if self.client.features.firmware_variant[0:8] == "Emulator":
self.skipTest("Skip until emulator issue resolved")
return
self.requires_firmware("7.1.0")
self.setup_mnemonic_nopin_nopassphrase()

Expand Down
Loading