fix(tokens): remove retired Ethereum contract entries - #536
Merged
Conversation
BNB, CMT, GTO, IOST, MCO, ODEM and QTUM each migrated off Ethereum or died. The vetted source now gives three competing addresses for six of them and none at all for ODEM, so the generator refuses them -- it takes a symbol only when the source gives exactly one address, so a scam token cannot inherit a real one's label. The device was advertising seven tokens it cannot identify. Coins resolve by name, never by table index, and no index is persisted, so removing entries cannot shift the meaning of stored data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes seven retired ERC-20 contract entries that no longer exist on Ethereum: QTUM ICO, BNB, GTO, IOST, CMT, MCO, and ODEM.
Also tightens the evolved coin-table test allowlist so only the intentional ZIL duplicate remains, and adds a regression test proving the retired contract entries cannot silently return. Native Qtum is unchanged.
Verification: