Dedupe beta-coefficients and logistic-regression column metadata - #32
Merged
Conversation
…gression The two file types share the same three columns (variable, coefficient, type) so their rows in column-metadata.csv are now merged using a semicolon-separated fileName (e.g. "beta-coefficients;logistic-regression"). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Older Quarto versions (1.3.x) don't propagate renv's R_LIBS_* env vars to post-render Rscript subprocesses, don't fire post-render hooks for file-less renders used by the generate-llms-md tests, and don't propagate post-render script errors as non-zero exit codes. Pinning a floor surfaces these incompatibilities at render time instead of as mysterious test failures. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
yulric
force-pushed
the
column-metadata-refactor
branch
from
June 9, 2026 14:42
582919a to
e16f3ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variable/coefficient/typerows forbeta-coefficientsandlogistic-regressionininst/metadata/column-metadata.csvinto single rows using a semicolon-separatedfileName(e.g.beta-coefficients;logistic-regression)..matches_file_type()helper inR/validate-model-paramater-file.Rso the multi-valuefileNameconvention is handled in one place.validate-model-paramater-file.R,create-reference-Rmd.R,create-Rmd-table.R) to use the helper.beta-coefficients/logistic-regression. The same pattern can later be applied to other duplicated rows and tocolumn-category.csv.Test plan
testthat::test_local(filter = "validate")— both validate tests pass, including the one exercising abeta-coefficientsfile.beta-coefficientsandlogistic-regressionreturn the merged rows; unrelated lookups (e.g.variables) are unaffected.🤖 Generated with Claude Code