HTNPoRT changes - #31
Merged
Merged
Conversation
yulric
commented
Oct 30, 2025
yulric
left a comment
yulric
left a comment
Contributor
Author
There was a problem hiding this comment.
- Fix the
logistictypo in the first commit - Add a test for
fixed bug in validate_model_parameter_file where the files referenced in a model step file were not being validated - Remove magic strings
- Squash
added metadata for the logistic regression fileinto the first commit - Squash
added category metadata for the type column in a logistic regression fileinto the first commit
yulric
force-pushed
the
htnport-changes
branch
2 times, most recently
from
November 1, 2025 01:09
5cbf5b1 to
fbe924c
Compare
yulric
force-pushed
the
htnport-changes
branch
4 times, most recently
from
November 1, 2025 01:23
08e4cda to
2796cb6
Compare
… in a model step file were not being validated
With the old return values, the only way to check if validation passed was to check if the returned value was TRUE. However, when validation failed and the function returned the list of errors, this check would generate a warning from R "the condition has length > 1 and only the first element will be used". With this change, users can check the `success` field for TRUE to see if validation passed, and since its never a vector, the above warning will never be generated.
…talk about the intercept
yulric
force-pushed
the
htnport-changes
branch
from
November 1, 2025 01:24
2796cb6 to
7861977
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes related to getting the HTNPoRT algorithm working