Restore server-affine offline reward replay#278
Merged
Conversation
BenCodez
marked this pull request as ready for review
July 19, 2026 22:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
forceRunOfflineRewards()as the explicit administrative bypass.Serverplaceholder.Root cause
Commit
0df8cc6eaddedsetGiveOffline(false).forceOffline()to normalcheckOfflineRewards()processing while refactoring login checks. That bypassed the injectedServerrequirement and prevented mismatched rewards from being requeued for their originating backend.VotingPlugin already calls
setServer(true)for proxy-delivered backend rewards. With this change, normal replay once again allows a server mismatch to fail withallowReattempt()and remain queued until the player reaches the matching backend.Validation
forceOffline=false,giveOffline=true, and preservesServer.forceOffline=trueandgiveOffline=false.