Skip to content

Restore server-affine offline reward replay#278

Merged
BenCodez merged 1 commit into
masterfrom
agent/restore-server-affine-offline-rewards
Jul 19, 2026
Merged

Restore server-affine offline reward replay#278
BenCodez merged 1 commit into
masterfrom
agent/restore-server-affine-offline-rewards

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

What changed

  • Stop forcing normal offline reward replay and restore the default requeue behavior.
  • Preserve forceRunOfflineRewards() as the explicit administrative bypass.
  • Add regression tests for both normal and forced replay options, including preservation of the stored Server placeholder.

Root cause

Commit 0df8cc6e added setGiveOffline(false).forceOffline() to normal checkOfflineRewards() processing while refactoring login checks. That bypassed the injected Server requirement and prevented mismatched rewards from being requeued for their originating backend.

VotingPlugin already calls setServer(true) for proxy-delivered backend rewards. With this change, normal replay once again allows a server mismatch to fail with allowReattempt() and remain queued until the player reaches the matching backend.

Validation

  • Added unit coverage asserting normal replay uses forceOffline=false, giveOffline=true, and preserves Server.
  • Added coverage asserting the explicit force-run path still uses forceOffline=true and giveOffline=false.
  • Local Maven execution was unavailable in the agent environment because Maven is not installed; CI should run the suite.

@BenCodez
BenCodez marked this pull request as ready for review July 19, 2026 22:04
@BenCodez
BenCodez merged commit 984e8b0 into master Jul 19, 2026
4 checks passed
@BenCodez
BenCodez deleted the agent/restore-server-affine-offline-rewards branch July 19, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant