Add support for aggregation in the creation of sparse matrices - #5527
Merged
Conversation
Signed-off-by: Oliver Alvarado Rodriguez <oliver.alvarado-rodriguez@hpe.com>
Signed-off-by: Oliver Alvarado Rodriguez <oliver.alvarado-rodriguez@hpe.com>
Signed-off-by: Oliver Alvarado Rodriguez <oliver.alvarado-rodriguez@hpe.com>
Also, no need to use += when the summation already occurred. Fixes a bug with the custom copy aggregation code where we need to be locking the domain while we're inserting values. Otherwise, 'find' will return bogus indices to insert the data. Finally, perform some cleanup of the original effort.
My initial attempt at using '_value' ran into an issue in PrivateDist's implementation, where it would assume that when dsiAccess was called that 'this.locale == here'. When 'flush' was initiated from a locale other than Locale0, it would grab the wrong lock, and a data race would ensue. Some kind of locale-private variable that could be declared over an array of locales would be useful here.
jabraham17
reviewed
Sep 2, 2026
jabraham17
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use an aggregator when creating a sparse matrix. This
CustomCopyAggregationworks similarly to other aggregators, and accepts a 3-tuple of the indices and corresponding value. These 3-tuples are then flushed by utilizing the pre-existingSparseIndexBuffer, which adds indices in bulk. This work is almost entirely from the initial effort of @alvaradoo , with only a few minor performance tweaks and a bug fix by myself.A new config param,
aggregatedSparseMatrixCreation, has been added to toggle this functionality.This PR also adds a
to_scipy_sparsemethod to sparse matrices, to help support correctness tests.A new benchmark for sparse matrix performance is also added to measure both multiplication time and matrix-creation time.
Other notes:
to_pdarrays[reviewed-by @jabraham17]