Fork Sync Branch 18.0 - #87
Merged
Merged
Conversation
The /vault/inbox/<token> route renders the vault.inbox template which calls web.login_layout. When the website module is installed it overrides web.login_layout to render website.layout, which requires the 'website' value in the render context. That value is only injected when the request is flagged as a frontend request (request.is_frontend), which in turn is derived from the route's website=True flag. Without it, rendering the shared-secret page crashed with KeyError: 'website'.
A batched create() results in several records and the guard accessed the non-stored related field allowed_share on the whole set, triggering ensure_one() -> 'Expected singleton: vault.right(...)'.
sireko
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.