Level property not found properly - #1685
Merged
michal-pekacki merged 2 commits intoAug 4, 2026
Merged
Conversation
Level.cs: introduce a local Level variable and change lookup flow to prefer LevelParameter and family host, then fall back to Document.LevelBelow(location) instead of returning null. LevelParameter.cs: adjust LINQ selection to use ThenByDescending on IsReadOnly and call FirstOrDefault() (remove predicate) so the candidate is chosen via ordered ranking (valid ElementIds first, then read-only ordering). This makes level resolution more robust and centralizes parameter selection logic.
michal-pekacki
approved these changes
Aug 3, 2026
michal-pekacki
left a comment
michal-pekacki
left a comment
Contributor
There was a problem hiding this comment.
Changes make sense, happy to approve 👍
Contributor
Author
|
@BHoMBot check required |
Contributor
|
@BHoMBot check versioning |
|
@michal-pekacki to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
Contributor
|
@BHoMBot check ready-to-merge |
|
@michal-pekacki to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
michal-pekacki
deleted the
Revit_Toolkit-#1684-LevelPropertyNotFoundProperly
branch
August 4, 2026 15:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Level.cs: introduce a local Level variable and change lookup flow to prefer LevelParameter and family host, then fall back to Document.LevelBelow(location) instead of returning null. LevelParameter.cs: adjust LINQ selection to use ThenByDescending on IsReadOnly and call FirstOrDefault() (remove predicate) so the candidate is chosen via ordered ranking (valid ElementIds first, then read-only ordering). This makes level resolution more robust and centralizes parameter selection logic.
NOTE: Depends on
Issues addressed by this PR
Closes #1684
Test files
Changelog
Additional comments