Manage positions page implementation#658
Open
conwelld wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #644
Changes
Created a position route in the main route.
Queried data from the positions history to filter the active positions in history and pass to managepositions.html
Added managepositions.css, where some CSS logic is handled
Added managepositions.js, where the datatable logic is handled
added logic to preserve allocation privacy
Testing
Worked around the data and UI through inspection
Made sure the passed data is displayed by cross-checking on the database.
changed it to if a user changes the url to another department, th euser can not see other department's allocations if they are not a labor admin