Removed --skip-ssl from reset_database.sh#655
Open
BetterRocket wants to merge 1 commit into
Open
Conversation
ArtemKurasov
left a comment
ArtemKurasov
left a comment
There was a problem hiding this comment.
No one uses dev containers, so these changes should be fine
|
This should be good, but if the next batch of students uses devcontainers, the README should reflect this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
--skip-sslis present in department-portal-base, but no one is using dev containers anymore so--skip-sslnow causes an sql alchemy error. It's now deprecated in the newer mysql version that runs in the non-container WSL setup, and is entirely redundant.Fixes #add issue number
Making the issue would take longer than fixing the problem.
Changes
--skip-sslfromreset_database.shTesting
reset_database.sh--skip-ssl