feat: support join & leave for member controllers - #184
Draft
Zhiying Lin (zhiying-lin) wants to merge 2 commits into
Draft
feat: support join & leave for member controllers#184Zhiying Lin (zhiying-lin) wants to merge 2 commits into
Zhiying Lin (zhiying-lin) wants to merge 2 commits into
Conversation
Zhiying Lin (zhiying-lin)
marked this pull request as draft
July 15, 2024 09:58
Zhiying Lin (zhiying-lin)
force-pushed
the
join-leave-1
branch
from
July 15, 2024 11:46
d458afc to
0fbb46e
Compare
Zhiying Lin (zhiying-lin)
force-pushed
the
join-leave-1
branch
2 times, most recently
from
July 23, 2024 07:34
4289d12 to
0f3b9e9
Compare
Zhiying Lin (zhiying-lin)
force-pushed
the
join-leave-1
branch
from
August 5, 2024 10:54
0f3b9e9 to
484f26c
Compare
Zhiying Lin (zhiying-lin)
force-pushed
the
join-leave-1
branch
from
August 5, 2024 11:05
484f26c to
b513116
Compare
Zhiying Lin (zhiying-lin)
marked this pull request as ready for review
August 5, 2024 11:11
michaelawyu (michaelawyu)
left a comment
michaelawyu (michaelawyu)
left a comment
Collaborator
There was a problem hiding this comment.
Just a few nits, LGTM.
Zhiying Lin (zhiying-lin)
force-pushed
the
join-leave-1
branch
from
August 7, 2024 05:54
614d055 to
c884bc0
Compare
Zhiying Lin (zhiying-lin)
marked this pull request as draft
August 8, 2024 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Run e2e test in the local
Special notes for your reviewer
Note: the changes will break v1alpha1 imc feature.