Sync eng/common directory with azure-sdk-tools for PR 16431 - #49989
Open
azure-sdk-automation[bot] wants to merge 1 commit into
Open
Sync eng/common directory with azure-sdk-tools for PR 16431#49989azure-sdk-automation[bot] wants to merge 1 commit into
azure-sdk-automation[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Removes Azure Pipelines definitions used to run Copilot instruction AI evaluation tests.
Changes:
- Deleted the reusable job template that executes the eval
dotnet testrun. - Deleted the pipeline entrypoint that triggered the eval job on changes to Copilot instructions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/pipelines/templates/jobs/ai-eval-job.yml | Removes the shared job template that performed sparse checkout + AzureCLI-based eval execution. |
| eng/common/pipelines/ai-evals-tests.yml | Removes the pipeline that triggered and extended the shared eval job template. |
Comments suppressed due to low confidence (2)
eng/common/pipelines/ai-evals-tests.yml:1
- Deleting this pipeline removes the only visible trigger that runs AI evals when
.github/copilot-instructions.md(and related instruction paths) change. If the intent is to keep eval coverage, add/point to a replacement pipeline (or migrate this trigger elsewhere) so instruction changes still get validated automatically; otherwise, document the decommissioning and how/when evals are expected to run going forward.
eng/common/pipelines/templates/jobs/ai-eval-job.yml:1 - With the job template removed, any remaining pipeline(s) or docs that referenced
/eng/common/pipelines/templates/jobs/ai-eval-job.ymlwill now fail or become stale. If this is an intentional removal, consider also removing/updating any references in-repo (e.g., other pipeline YAMLs, docs) to avoid broken extends/template paths.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16431 See eng/common workflow