Skip to content

[discovery] Add azure-ai-discovery 1.0.0 (GA) - #49932

Open
ahall-msft wants to merge 2 commits into
mainfrom
discovery-dataplane-1.0.0
Open

[discovery] Add azure-ai-discovery 1.0.0 (GA)#49932
ahall-msft wants to merge 2 commits into
mainfrom
discovery-dataplane-1.0.0

Conversation

@ahall-msft

@ahall-msft ahall-msft commented Jul 27, 2026

Copy link
Copy Markdown
Member

Initial GA (1.0.0) release of the Microsoft Discovery data-plane SDK, com.azure:azure-ai-discovery. Tracked by data-plane release plan 2205 (GA – Microsoft Discovery).

Generated from the merged, public GA spec:

What's included

  • New package sdk/discovery/azure-ai-discovery/ (WorkspaceClient/BookshelfClient + async, generated).
  • New sdk/discovery/pom.xml (aggregator) and sdk/discovery/ci.yml (artifact azure-ai-discovery).
  • Root pom.xml reactor entry sdk/discovery; eng/versioning/version_client.txt entry; .vscode/cspell.json scoped override (milli, invst).

Release Plan Details

Initial GA release of the Discovery data-plane SDK, generated from the merged
public GA spec (specification/discovery/Discovery.Combined @ fbe3c49, PR
Azure/azure-rest-api-specs#42884), api-version 2026-06-01. Recordings externalized
to Azure/azure-sdk-assets (tag java/discovery/azure-ai-discovery_2380bf9632).
@github-actions github-actions Bot added the common common module used by all azure SDKs (e.g. client, Mgmt) label Jul 27, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
34 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@ahall-msft
ahall-msft marked this pull request as ready for review July 27, 2026 08:00
@ahall-msft
ahall-msft requested a review from a team as a code owner July 27, 2026 08:00
Copilot AI review requested due to automatic review settings July 27, 2026 08:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
34 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Comment on lines +41 to +42
```java com.azure.ai.discovery.readme
```

@weidongxu-microsoft weidongxu-microsoft Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have at least one sample to get user started. Put it in ReadmeSamples.java, and it should sync here.


### Features Added

- `WorkspaceClient` and `WorkspaceAsyncClient` for working with Discovery workspaces, including conversations, investigations, tasks, and tools.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no WorkspaceClient in code.

*/
@Generated
@ServiceMethod(returns = ReturnType.SINGLE)
public PagedOperation getOperations(String projectName, Integer top, Integer skip, Integer maxPageSize) {

@weidongxu-microsoft weidongxu-microsoft Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something wrong in the TypeSpec.
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/discovery/Discovery.Workspace/_tool.tsp#L550-L559

This should be a paged operation, aka PagedIterable<Operation>.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be more.

Basically, if the response is CustomPage<Something>, the operation should be a @list

@weidongxu-microsoft weidongxu-microsoft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional GA API-surface findings.

*/
@Generated
@ServiceMethod(returns = ReturnType.SINGLE)
public Conversation stableUpdate(String conversationName, Conversation resource) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stableUpdate is an internal TypeSpec version-split name, but it is leaking into the initial GA Java API (and the same happens for Tasks). This will permanently expose stableUpdate/stableUpdateWithResponse instead of the expected update methods. Please apply a Java client name override in TypeSpec (for both Conversations and Tasks) and regenerate before 1.0.0.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be just update in client

*/
@Generated
@ServiceMethod(returns = ReturnType.LONG_RUNNING_OPERATION)
public SyncPoller<PollOperationDetails, RunResult> beginCancelRunLro(String projectName, String operationId) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, cancelRunLro exposes an implementation/versioning suffix in the public GA API. The customer-facing method should be beginCancelRun (with the protocol method named consistently), using a client-name override if the TypeSpec operation must retain cancelRunLro internally.

Adds PRLabel/ServiceLabel %Discovery and AzureSdkOwners/ServiceOwners for /sdk/discovery/, matching the Python data-plane PR.
@ahall-msft
ahall-msft requested a review from a team as a code owner July 31, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common common module used by all azure SDKs (e.g. client, Mgmt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants